Clean up stubtest allowlist for typing #10205
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like there's a few real bugs in there -- e.g. several classes that aren't decorated with |
|
Yes, going through it now. There's also some missing entries in |
AlexWaygood
reviewed
May 24, 2023
Comment on lines
+456
to
+458
| # Internal attributes | ||
| .*\.__protocol_attrs__ | ||
| .*\.__callable_proto_members_only__ |
There was a problem hiding this comment.
python/mypy#15294 means we should be able to remove these, come the next mypy release
(No change requested)
AlexWaygood
reviewed
May 24, 2023
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Going to do some CI-driven development here