Skip to content

feat: adding sagemaker raw stubs #10355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 12 commits into from
Closed

feat: adding sagemaker raw stubs #10355

wants to merge 12 commits into from

Conversation

DemyCode
Copy link

This pull request adds the sagemaker typing to typeshed.
Sagemaker has no stub available on the internet.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@DemyCode
Copy link
Author

Hello @AlexWaygood
What is ruff ? I was currently implementing scripts that will introduce the changes you just made

@AlexWaygood
Copy link
Member

ruff is a linter for Python that has many autofixes. We don't include it in our CI yet, but a lot of the autofixes it contains can be pretty useful for typeshed PRs. I ran ruff stubs/sagemaker --select="UP006,UP007,UP035,RUFF013" --fix on your PR branch to reduce the number of CI errors you would have had to deal with :)

@DemyCode
Copy link
Author

ok thanks a lot ! I will have a look at it also

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@AlexWaygood AlexWaygood reopened this Jul 20, 2023
@github-actions

This comment has been minimized.

@github-actions
Copy link
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@DemyCode DemyCode closed this by deleting the head repository Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants