pytype_test.py: Use importlib.metadata instead of pkg_resources #10391
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexWaygood
commented
Jun 30, 2023
| @@ -72,7 +72,7 @@ for this script. | |||
|
|
|||
| Note: this test cannot be run on Windows | |||
| systems unless you are using Windows Subsystem for Linux. | |||
| It also requires a Python version < 3.11 as pytype does not yet support | |||
| It can currently only be run on Python 3.10 as pytype does not yet support | |||
There was a problem hiding this comment.
We could avoid this if we added the importlib_metadata backport as a test dependency
There was a problem hiding this comment.
I prefer the narrow requirements in this case. I would be surprised if pytype_test is much run manually and an extra requirement can always be a bit of a pain.
There was a problem hiding this comment.
I agree, though I don't have a strong opinion at all
AlexWaygood
commented
Jun 30, 2023
hauntsaninja
approved these changes
Jun 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My hope is that this will resolve the pytype failures in #10389. It's probably a good idea to do this anyway, though, since
pkg_resourcesis deprecated.