Skip to content

Fix type hints in email module #10450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 17, 2023
Merged

Fix type hints in email module #10450

merged 4 commits into from
Jul 17, 2023

Conversation

cushionbadak
Copy link
Contributor

Closes #10444

I'm curious whether the return type of the methods that call header_factory should also be modified to Any. This applies to methods such as header_fetch_parse and fold , the latter of which internally calls the _fold method.

typeshed/stdlib/email/policy.pyi

Lines 74 to 75 in ad3648d

def header_fetch_parse(self, name: str, value: str) -> str: ...
def fold(self, name: str, value: str) -> str: ...

@github-actions

This comment has been minimized.

Sign in to view
@github-actions
Copy link
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

srittau
srittau approved these changes Jul 17, 2023
View reviewed changes
Copy link
Collaborator

@srittau srittau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@srittau srittau merged commit a048220 into python:main Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srittau srittau srittau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Correcting type mismatches in the email module
2 participants
@cushionbadak @srittau