-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Make pytype respect required python versions of stubs #10810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This is the pytype part of python#10722
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
colors, keep summary at the end, file before error stack, better alignment
I just posted some explanation in #10722 (comment) of the context/history around why we pytype and pyright are run so differently from mypy in CI. The result of all that is that typeshed/.github/workflows/tests.yml Lines 71 to 80 in 3eb9ff7
(This probably isn't an ideal state of affairs; we should probably alter As a result, I think this PR as it currently stands is insufficient, since |
Thanks for the context. I’ll close this now. |
No worries. Sorry I wasn't clearer earlier about the "philosophical difference" between this script and the mypy scripts :( |
Don’t worry about it. I was happy it worked locally that I forgot to look how it works in CI. I will look into it again in the future when I get some time and if no one else beats me to it. |
This is the pytype part of #10722