seaborn: complete and fix axisgrid module #11096
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
hamdanal
commented
Dec 2, 2023
| x: ColumnName | _Vector | None = None, | ||
| y: ColumnName | _Vector | None = None, | ||
| hue: ColumnName | _Vector | None = None, | ||
| kind: Literal["scatter", "kde", "hist", "hex", "reg", "resid"] = "scatter", |
There was a problem hiding this comment.
This was changed to str earlier thanks to the feedback on the PR that introduced seaborn stubs. Upon further investigation, the function seems to only accepts this set of strings (also verified in the repl).
Comment on lines
-130
to
+288
| diag_vars: NDArray[Incomplete] | None # array of `str` | ||
| diag_axes: NDArray[Incomplete] | None # array of `Axes` | ||
| diag_vars: list[str] | None | ||
| diag_axes: list[Axes] | None |
There was a problem hiding this comment.
These are lists, not sure why I typed them as arrays earlier
Comment on lines
-63
to
+214
| data: DataFrame, | ||
| data: DataFrame | _SupportsDataFrame, |
There was a problem hiding this comment.
seaborn version 0.13 started supporting other data frames that support the __dataframe__ protocol: https://seaborn.pydata.org/whatsnew/v0.13.0.html#support-for-alternate-dataframe-libraries
srittau
approved these changes
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.