Add defaults for tkinter __init__ methods
#11391
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NOTE: Listbox `exportselection` param type might be wrong, should perhaps be `bool`, not `int`, like all the other `exportselection` params
NOTE: not sure what to put for `Message(padx, pady)`. The default is always `"-1"` but the pad value must be positive, see https://tcl.tk/man/tcl8.6/TkCmd/options.htm#M-padx#:~:text=Command%2DLine%20Name%3A%20%2Dpadx,Specifies%20a%20non%2Dnegative%20value
Make it an actual `int` it is compatible with the `_TakeFocusValue` type
Akuli
reviewed
Feb 10, 2024
|
Are you going to make a separate PR that does this for I mostly use the ttk widgets in my projects, because I can apply an awesome theme to them. I think a separate PR for ttk widgets would be easier to review than adding their defaults to this PR. This way, we won't get confused about
This is small compared to my biggest autogenerated tkinter PR :) |
This comment has been minimized.
This comment has been minimized.
…0"` on all platforms
This comment has been minimized.
This comment has been minimized.
… a string For the rest of the integer-in-strings, the default value is consistently a string on all platforms, so I'm not sure if I should replace those with a plain integer (this would probably be more useful in IDEs but less accurate)
Yes |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Akuli
reviewed
Feb 10, 2024
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Akuli
approved these changes
Feb 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add defaults for
tkinter's__init__methods, see #10947The defaults I filled in are consistent across:
All available github actions runners:
ubuntu-20.04,ubuntu-22.04windows-2019,windows-2022macos-11,macos-12,macos-13I used a script to generate the defaults into a JSON file (source code at https://github.com/MarcellPerger1/typeshed-tkinter-defaults), then I filled them into the arguments by hand (I also checked them with the tcl.tk documentation to ensure the defaults make sense).
I tried to fill the defaults in a way that keeps the defaults value consistent with the argument type (while still keeping it close to the types returned by
.cget).Some notes about specific arguments:
variableandtextvariable: The default value (usingdict) is consistently""but this doesn't match the annotatedVariabletype so I didn't fill these inMessage(padx, pady): The default value is-1which is not allowed according to the documentation so I didn't fill this inToplevel(use): The default value is always""but this doesn't match the annotatedinttype so I didn't fill this inP.S. Sorry for the huge diff.