Skip to content

Make slice generic #11637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Oct 24, 2024
Merged

Make slice generic #11637

Changes from all commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
9628936
Make slice generic
Sachaa-Thanasius Mar 20, 2024
9588575
Fix typo in _StartT as default for _StopT
Sachaa-Thanasius Mar 20, 2024
956d74f
Merge branch 'main' into generic-slice
Sachaa-Thanasius Mar 21, 2024
ff3d6e7
Merge branch 'main' into generic-slice
Sachaa-Thanasius Mar 23, 2024
3e52ed5
Merge branch 'main' into generic-slice
Sachaa-Thanasius Mar 29, 2024
307ed3c
Merge branch 'main' into generic-slice
Sachaa-Thanasius Apr 24, 2024
f451d34
Merge branch 'main' into generic-slice
Sachaa-Thanasius May 3, 2024
b16b8dc
Merge branch 'main' into generic-slice
Sachaa-Thanasius Jun 2, 2024
cdd8fc2
Trying defaults that are more accurate to the runtime
Sachaa-Thanasius Jun 2, 2024
ed843dc
Attempt making the defaults `Any`
Sachaa-Thanasius Jun 4, 2024
5ce829f
Merge branch 'python:main' into generic-slice
Sachaa-Thanasius Jun 4, 2024
02fdc1e
Try making the typevars covariant, per feedback
Sachaa-Thanasius Jun 5, 2024
59e38ce
Merge branch 'python:main' into generic-slice
Sachaa-Thanasius Jun 5, 2024
8c25be1
Merge branch 'main' into generic-slice
AlexWaygood Oct 24, 2024
15da628
fix failing test
AlexWaygood Oct 24, 2024
0692cd0
Hedge
AlexWaygood Oct 24, 2024
bb9252f
`Any` it is...
AlexWaygood Oct 24, 2024
b98c8fa
There's no problem in this universe that cannot be fixed by adding mo…
AlexWaygood Oct 24, 2024
c0fe293
more Any again
AlexWaygood Oct 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 18 additions & 6 deletions stdlib/builtins.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ from _typeshed import (
ConvertibleToFloat,
ConvertibleToInt,
FileDescriptorOrPath,
MaybeNone,
OpenBinaryMode,
OpenBinaryModeReading,
OpenBinaryModeUpdating,
Expand Down Expand Up @@ -94,6 +95,9 @@ _SupportsAnextT = TypeVar("_SupportsAnextT", bound=SupportsAnext[Any], covariant
_AwaitableT = TypeVar("_AwaitableT", bound=Awaitable[Any])
_AwaitableT_co = TypeVar("_AwaitableT_co", bound=Awaitable[Any], covariant=True)
_P = ParamSpec("_P")
_StartT = TypeVar("_StartT", covariant=True, default=Any)
_StopT = TypeVar("_StopT", covariant=True, default=Any)
_StepT = TypeVar("_StepT", covariant=True, default=Any)

class object:
__doc__: str | None
Expand Down Expand Up @@ -936,17 +940,25 @@ class bool(int):
def __invert__(self) -> int: ...

@final
class slice:
class slice(Generic[_StartT, _StopT, _StepT]):
@property
def start(self) -> Any: ...
def start(self) -> _StartT: ...
@property
def step(self) -> Any: ...
def step(self) -> _StepT: ...
@property
def stop(self) -> Any: ...
def stop(self) -> _StopT: ...
@overload
def __new__(cls, stop: Any, /) -> Self: ...
def __new__(cls, stop: int | None) -> slice[int | MaybeNone, int | MaybeNone, int | MaybeNone]: ...
@overload
def __new__(cls, start: Any, stop: Any, step: Any = ..., /) -> Self: ...
def __new__(
cls, start: int | None, stop: int | None, step: int | None = None
) -> slice[int | MaybeNone, int | MaybeNone, int | MaybeNone]: ...
@overload
def __new__(cls, stop: _T2, /) -> slice[Any, _T2, Any]: ...
@overload
def __new__(cls, start: _T1, stop: _T2, /) -> slice[_T1, _T2, Any]: ...
@overload
def __new__(cls, start: _T1, stop: _T2, step: _T3, /) -> slice[_T1, _T2, _T3]: ...
def __eq__(self, value: object, /) -> bool: ...
if sys.version_info >= (3, 12):
def __hash__(self) -> int: ...
Expand Down
Loading