Update to mypy 1.14 #13272
Merged
Update to mypy 1.14 #13272
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
|
Just one allowlist entry for the stdlib I guess; working on allowlisting the missing third-party |
This comment has been minimized.
This comment has been minimized.
No, the sooner the better! Thanks for working on this. |
| @@ -8,15 +8,15 @@ class SignatureFlag(IntEnum): | |||
| SIGNATURES_EXIST = 1 | |||
| APPEND_ONLY = 2 | |||
|
|
|||
| class CoerciveEnum(Enum): | |||
| class CoerciveEnum(Enum): # type: ignore[misc] # Enum with no members | |||
There was a problem hiding this comment.
That might be a false positive? An enum with no members is OK, it makes an abstract class.
There was a problem hiding this comment.
Yeah; mypy is flagging them with an error like this:
error: Detected enum "fpdf.enums.CoerciveEnum" in a type stub with zero members. There is a chance this is due to a recent change in the semantics of enum membership. If so, use `member = value` to mark an enum member, instead of `member: type` [misc]
I didn't check whether there's a better way to silence that.
| @@ -29,10 +29,10 @@ priv_bytes: Incomplete | |||
| JWKTypesRegistry: Incomplete | |||
|
|
|||
| class ParmType(Enum): | |||
There was a problem hiding this comment.
Unrelated but I'm pretty sure this is a typo for "Param" in the runtime package.
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know if you normally wait a little before moving to the new version of mypy in typeshed. Personally, I've been waiting for it to come out because disentangling
types.DynamicClassAttributefrombuiltins.propertyis one of the last things on my inheritance check todo list, and python/mypy#18150 in the new version enables that.Just one new allowlist entry needed, which will be resolved by #13038 if/when it's accepted.