Enable Ruff flake8-use-pathlib (PTH) #13795
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-Ruff-flake8-use-pathlib-(PTH)
srittau
reviewed
Apr 4, 2025
lib/ts_utils/utils.py
Outdated
| @@ -203,7 +203,7 @@ def allowlists(distribution_name: str) -> list[str]: | |||
|
|
|||
| @functools.cache | |||
| def get_gitignore_spec() -> pathspec.PathSpec: | |||
| with open(".gitignore", encoding="UTF-8") as f: | |||
| with Path(".gitignore").open(encoding="UTF-8") as f: | |||
There was a problem hiding this comment.
I prefer the simple open() in this and similar cases. But it's no deal breaker for me. The rest looks good.
Avasam
commented
Apr 4, 2025
….com/Avasam/typeshed into Enable-Ruff-flake8-use-pathlib-(PTH)
…-Ruff-flake8-use-pathlib-(PTH)
Avasam
commented
May 3, 2025
lib/ts_utils/requirements.py
Outdated
Comment on lines
16
to
22
| distributions = os.listdir(STUBS_PATH) | ||
| distributions = [distribution.name for distribution in STUBS_PATH.iterdir()] | ||
|
|
||
| return set(itertools.chain.from_iterable([read_dependencies(distribution).external_pkgs for distribution in distributions])) | ||
|
|
||
|
|
||
| def get_stubtest_system_requirements(distributions: Iterable[str] = (), platform: str = sys.platform) -> list[str]: | ||
| if not distributions: | ||
| distributions = os.listdir(STUBS_PATH) | ||
| distributions = [distribution.name for distribution in STUBS_PATH.iterdir()] |
There was a problem hiding this comment.
This seems like a straight up downgrade.
os-listdir (PTH208)
Only one other change of os.listdir --> Path.iterdir seems like an actual improvement. (in tests/mypy_test.py)
Avasam
commented
May 3, 2025
tests/mypy_test.py
Outdated
| @@ -472,7 +472,7 @@ def test_third_party_stubs(args: TestConfig, tempdir: Path) -> TestSummary: | |||
| gitignore_spec = get_gitignore_spec() | |||
| distributions_to_check: dict[str, PackageDependencies] = {} | |||
|
|
|||
| for distribution in sorted(os.listdir("stubs")): | |||
| for distribution in sorted([distribution.name for distribution in STUBS_PATH.iterdir()]): | |||
There was a problem hiding this comment.
This seems like a straight up downgrade.
os-listdir (PTH208)
Only one other change of os.listdir --> Path.iterdir seems like an actual improvement. (in add_third_party_files above)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kept this one for last. Closes #13295
Some rules in this group are forcing some refactoring to use
pathlib. In some cases, it's a lot cleaner, in others it's debatable.I unconditionally followed all the rules. Please indicate changes you disagree with/preferred in the old style. I'll revert those and disable the relevant rules.
There's also a few
with readandwith writethat can be further rewritten to be more concise withPath.read_textandPath.write_text