Fix base class compatibility for IntFlag in Python 3.11+ to resolve inverted type issue #13854
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nverted type issue
This comment has been minimized.
This comment has been minimized.
stdlib/enum.pyi
Outdated
| @@ -299,6 +299,7 @@ if sys.version_info >= (3, 11): | |||
| def __or__(self, other: int) -> Self: ... | |||
| def __and__(self, other: int) -> Self: ... | |||
| def __xor__(self, other: int) -> Self: ... | |||
| def __invert__(self) -> IntFlag: ... | |||
There was a problem hiding this comment.
Suggested change
| def __invert__(self) -> IntFlag: ... | |
| def __invert__(self) -> Self: ... |
stdlib/enum.pyi
Outdated
| @@ -309,6 +310,7 @@ else: | |||
| def __or__(self, other: int) -> Self: ... | |||
| def __and__(self, other: int) -> Self: ... | |||
| def __xor__(self, other: int) -> Self: ... | |||
| def __invert__(self) -> IntFlag: ... | |||
There was a problem hiding this comment.
Suggested change
| def __invert__(self) -> IntFlag: ... | |
| def __invert__(self) -> Self: ... |
There was a problem hiding this comment.
Thanks for the suggestion! @brianschubert I've made the changes you recommended.
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
|
I've updated the invert return type from IntFlag to Self as suggested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13853