Skip to content

Bump gevent to 25.4.* #13855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 25, 2025
Merged

Conversation

LordGvozd
Copy link

@LordGvozd LordGvozd commented Apr 19, 2025

Bump gevent to 25.4.* closes #13850

This comment has been minimized.

Copy link
Contributor

Diff from mypy_primer, showing the effect of this PR on open source code:

vision (https://github.com/pytorch/vision)
- torchvision/utils.py:271: error: Unused "type: ignore" comment  [unused-ignore]

@srittau srittau changed the title Fix PR #13850 Bump gevent to 25.4.* Apr 20, 2025
@sobolevn
Copy link
Member

@LordGvozd you can add closes #13850 (as regular text) to the PR's description. Then your PR will auto-close the first one, when merged.

Copy link
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sobolevn sobolevn merged commit 5f0f3b7 into python:stubsabot/gevent Apr 25, 2025
43 checks passed
@sobolevn
Copy link
Member

sobolevn commented Apr 25, 2025

@LordGvozd sorry, I've missed this during review :)
You made a PR to some other branch, not main. I merged your code to somewhere else.
Please, recreate your PR to main.

@sobolevn
Copy link
Member

@srittau maybe we should validate this in CI?

@srittau
Copy link
Collaborator

srittau commented Apr 25, 2025

We can just merge the stubsabot branch (once CI passes). I've reopened the stubsabot PR.

@srittau
Copy link
Collaborator

srittau commented Apr 25, 2025

CI doesn't pass: #13850, so per @sobolevn this needs to be recreated as a PR against main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants