Improve pywin32.isapi
#13889
Merged
Improve pywin32.isapi
#13889
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Avasam
approved these changes
Apr 27, 2025
Avasam
requested changes
Apr 27, 2025
Co-authored-by: Avasam <samuel.06@hotmail.com>
donBarbos
commented
Apr 27, 2025
Comment on lines
+87
to
+88
| def InstallModule(conf_module_name: StrPath, params, options, log: Callable[[int, str], Unused] = ...) -> None: ... | ||
| def UninstallModule(conf_module_name: StrPath, params, options, log: Callable[[int, str], Unused] = ...) -> None: ... |
There was a problem hiding this comment.
should it be sync with the log function?
Suggested change
| def InstallModule(conf_module_name: StrPath, params, options, log: Callable[[int, str], Unused] = ...) -> None: ... | |
| def UninstallModule(conf_module_name: StrPath, params, options, log: Callable[[int, str], Unused] = ...) -> None: ... | |
| def InstallModule(conf_module_name: StrPath, params, options, log: Callable[[int, object], Unused] = ...) -> None: ... | |
| def UninstallModule(conf_module_name: StrPath, params, options, log: Callable[[int, object], Unused] = ...) -> None: ... |
There was a problem hiding this comment.
@donBarbos My bad. I answered too fast. Here it means "this function expects to be passed a log parameter that should be a function that accepts a str as the 2nd parameter".
In other words, we want to ensure that whatever function will be passed here will work once a string is passed. The typing here is based on usage, it's completely separate from isapi.isntall.log
I went ahead and reverted the last commit.
|
thanks for helping get rid of |
This comment has been minimized.
This comment has been minimized.
This reverts commit 5e6a2d7.
Avasam
approved these changes
Apr 27, 2025
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.