Fix return type of win32wnet.WNetOpenEnum #13890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

Avasam merged 1 commit into python:main from petamas:fix-win32wnet.WNetOpenEnum

Apr 27, 2025

Contributor

petamas commented Apr 26, 2025

win32wnet.WNetOpenEnum returns a PyHANDLE, not an int.

See @Avasam's comment here:

>>> import win32wnet
>>> handle = win32wnet.WNetOpenEnum(RESOURCE_REMEMBERED, RESOURCETYPE_DISK, 0, None)
>>> handle
<PyNetEnumHANDLE:2352947023664>

The wrong typehint makes the otherwise valid combination of WNetOpenEnum() and WNetEnumResource() fail mypy's checking.


          Fix return type of win32wnet.WNetOpenEnum

f6fe463

Contributor

github-actions bot commented Apr 26, 2025

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

Avasam approved these changes

View reviewed changes

Avasam requested review from Avasam and removed request for Avasam

April 27, 2025 04:55

Avasam merged commit 1ccaa7f into python:main

43 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet