Skip to content

None return type hint for SubsegmentContextManager.__enter__ #13892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 27, 2025

Conversation

tmlnv
Copy link
Contributor

@tmlnv tmlnv commented Apr 27, 2025

fix: Update return type hint for SubsegmentContextManager.enter in aws-xray-sdk to include None

The PR fixes issue 13883

Copy link
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

Copy link
Collaborator

@srittau srittau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@srittau srittau merged commit 0dedc39 into python:main Apr 27, 2025
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Return type hint for SubsegmentContextManager.__enter__ in aws-xray-sdk should include None
2 participants