Skip to content

Add ratelimit stubs #13909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 30, 2025
Merged

Add ratelimit stubs #13909

merged 1 commit into from
Apr 30, 2025

Conversation

Tatsh
Copy link
Contributor

@Tatsh Tatsh commented Apr 30, 2025

https://github.com/tomasbasham/ratelimit

As much as I'd like to contribute these to upstream, it seems very dead with a few PRs open and no responses from the author. However, the library still works.

@Tatsh Tatsh force-pushed the ratelimit branch 3 times, most recently from c04e4d1 to 80b3e53 Compare April 30, 2025 09:12

This comment has been minimized.

Copy link
Collaborator

@srittau srittau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, a few notes below.

This comment has been minimized.

@Tatsh Tatsh requested a review from srittau April 30, 2025 17:26
@srittau
Copy link
Collaborator

srittau commented Apr 30, 2025

@Tatsh This needs a ratelimit.decorators.now line in stubs/ratelimit/@tests/stubtest_allowlist.txt to pass CI. Sorry for the back and forth.

Copy link
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@srittau srittau merged commit eec809d into python:main Apr 30, 2025
43 checks passed
@Tatsh Tatsh deleted the ratelimit branch April 30, 2025 23:24
@Tatsh

This comment was marked as outdated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants