Fix __new__ issues in 3.14 #14626
Merged
Fix __new__ issues in 3.14 #14626
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Diff from mypy_primer, showing the effect of this PR on open source code: discord.py (https://github.com/Rapptz/discord.py)
- discord/ext/commands/hybrid.py:508: error: Overlap between argument names and ** TypedDict items: "name", "description" [misc]
+ discord/ext/commands/hybrid.py:508: error: Overlap between argument names and ** TypedDict items: "description", "name" [misc]
- discord/ext/commands/hybrid.py:629: error: Overlap between argument names and ** TypedDict items: "name", "description" [misc]
+ discord/ext/commands/hybrid.py:629: error: Overlap between argument names and ** TypedDict items: "description", "name" [misc]
- discord/ext/commands/hybrid.py:834: error: Overlap between argument names and ** TypedDict items: "name", "with_app_command" [misc]
+ discord/ext/commands/hybrid.py:834: error: Overlap between argument names and ** TypedDict items: "with_app_command", "name" [misc]
- discord/ext/commands/hybrid.py:858: error: Overlap between argument names and ** TypedDict items: "name", "with_app_command" [misc]
+ discord/ext/commands/hybrid.py:858: error: Overlap between argument names and ** TypedDict items: "with_app_command", "name" [misc]
- discord/ext/commands/hybrid.py:883: error: Overlap between argument names and ** TypedDict items: "name", "with_app_command" [misc]
+ discord/ext/commands/hybrid.py:883: error: Overlap between argument names and ** TypedDict items: "with_app_command", "name" [misc]
- discord/ext/commands/hybrid.py:935: error: Overlap between argument names and ** TypedDict items: "name", "with_app_command" [misc]
+ discord/ext/commands/hybrid.py:935: error: Overlap between argument names and ** TypedDict items: "with_app_command", "name" [misc]
- discord/ext/commands/bot.py:290: error: Overlap between argument names and ** TypedDict items: "name", "with_app_command" [misc]
+ discord/ext/commands/bot.py:290: error: Overlap between argument names and ** TypedDict items: "with_app_command", "name" [misc]
- discord/ext/commands/bot.py:314: error: Overlap between argument names and ** TypedDict items: "name", "with_app_command" [misc]
+ discord/ext/commands/bot.py:314: error: Overlap between argument names and ** TypedDict items: "with_app_command", "name" [misc]
|
AlexWaygood
reviewed
Aug 23, 2025
Comment on lines
+172
to
+181
| if sys.version_info >= (3, 14): | ||
| @overload | ||
| def __new__(self, func: Callable[..., _T], /, *args: Any, **keywords: Any) -> Self: ... | ||
| @overload | ||
| def __new__(self, func: _Descriptor, /, *args: Any, **keywords: Any) -> Self: ... | ||
| else: | ||
| @overload | ||
| def __init__(self, func: Callable[..., _T], /, *args: Any, **keywords: Any) -> None: ... | ||
| @overload | ||
| def __init__(self, func: _Descriptor, /, *args: Any, **keywords: Any) -> None: ... |
There was a problem hiding this comment.
It looks to me like functools.partial has __new__ rather than __init__ on Python 3.13 too?
Python 3.13.1 (main, Jan 3 2025, 12:04:03) [Clang 15.0.0 (clang-1500.3.9.4)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> import functools
>>> functools.partial.__new__
<built-in method __new__ of type object at 0x11d890810>
>>> functools.partial.__init__
<slot wrapper '__init__' of 'object' objects>
>>> functools.partial.__init__ is object.__init__
True
>>> functools.partial.__new__ is object.__new__
FalseThere was a problem hiding this comment.
This is partialmethod, not partial.
Python 3.13.6 (main, Aug 6 2025, 22:48:48) [Clang 20.1.4 ] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> import functools
>>> functools.partialmethod.__new__
<built-in method __new__ of type object at 0x1049a3b58>
>>> functools.partialmethod.__init__
<function partialmethod.__init__ at 0x1026911c0>
There was a problem hiding this comment.
Argh, sorry for misreading!
AlexWaygood
approved these changes
Aug 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More followup from python/mypy#18259, cc @tungol.