Improve werkzeug stubs #1730
Merged
Improve werkzeug stubs #1730
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
071d0d3 to
98367e1
Compare
|
Rebase and I'll take a look. |
|
MutableMapping definition is missing. |
|
Sorry for the bad merge, it's fixed now. |
|
@ambv could you take another look? |
|
LGTM. |
yedpodtrzitko
pushed a commit
to yedpodtrzitko/typeshed
that referenced
this pull request
Jan 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes a few default values that were not ...; adds missing types; harmonizes the stub between Python 2 and 3. We should merge the 2 and 3 stubs for this library, but that's a bigger project.
Mostly worked off https://github.com/pallets/werkzeug/blob/master/werkzeug/wrappers.py.