Skip to content

Change the return type of unittest.TestCase.fail() to NoReturn #1843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 26, 2018
Merged

Change the return type of unittest.TestCase.fail() to NoReturn #1843

merged 2 commits into from
Jan 26, 2018

Conversation

rchen152
Copy link
Collaborator

@rchen152 rchen152 commented Jan 25, 2018

fail() "signals a test failure unconditionally" (https://docs.python.org/2/library/unittest.html#unittest.TestCase.fail). Also alphabetizes the list of typing imports in stdlib/3/unittest/_init_.pyi.

@rchen152
Copy link
Collaborator Author

Ah, looks like this pull request can't be merged until pytype is updated to the version that contains NoReturn.

@JelleZijlstra
Copy link
Member

Importing it from mypy_extensions might work.

@rchen152
Copy link
Collaborator Author

That did the trick, thanks!

@JelleZijlstra JelleZijlstra merged commit 66e5863 into python:master Jan 26, 2018
@rchen152 rchen152 deleted the unittest branch January 26, 2018 22:29
rhysparry added a commit to rhysparry/typeshed that referenced this pull request Feb 8, 2018
* python/master: (269 commits)
  allow Optional[float] for asyncio.wait() timeout arg (python#1860)
  Clean up the pytype blacklist. (python#1851)
  filter function: make the callable of the first overload non-optional so that mypy is able to select the second overload for the  case. (python#1855)
  Accept Text in distutils *Version classes (python#1854)
  Add attrs library (python#1838)
  Add type stub for the lzma module (python#1844)
  Add ImportError attributes name, path for Python 3.3+ (python#1849)
  Add 'message' to click.decorators.version_option (python#1845)
  PEP 553 and PEP 564 (python#1846)
  Adding py36 additions to datetime module (python#1848)
  Remove incomplete thrift stubs that cause false positives. (python#1827)
  adding curses.ascii, curses.panel and curses.textpad modules (python#1792)
  Fix requests session hooks type (python#1794)
  Add StringIO.name and BytesIO.name (python#1802)
  Fix werkzeug environ type (python#1831)
  Change the return type of unittest.TestCase.fail() to NoReturn (python#1843)
  _curses.tparm works on bytes, not str (python#1828)
  Refine types for distutils.version (python#1835)
  Add stub for stat.filemode (python#1837)
  modify pytype_test to run from within pytype too, and support python3 (python#1817)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants