Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds partial support for
property
in thebuiltins
/__builtin__
module, fixing python/mypy#1529This allows subclassing
property
and some basic property behavior but it's got a few warts still:setter()
,getter()
, anddeleter()
on a subclass are by default the subclassed type, but mypy still thinks it's a 'property'. This is usually benign but can be annoying.@override
things. I think that's an issue with mypy's understanding of decorators.You can use the old non-decorator style of declaring your getter/setter/deleter and then calling everything with the constructor though.