dest argument to add_argument is Optional #2040
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
argparse.py checks for None in _get_optional_kwargs.
|
See https://github.com/python/cpython/blob/master/Lib/argparse.py#L1476. This fixes a CI failure introduced by #1937. |
|
Hm, what a pain. If I sync typeshed to this (after it's been merged) and cherry-pick the sync into the release-0.590 branch, I get a whole slew of extra typeshed PRs into the bargain. To play it safe I would have to create a typeshed release branch and cp this into that, then sync that branch into mypy. It's doable, but a bit convoluted. OTOH perhaps I'm being overly cautious. Let me see if just syncing to typeshed HEAD (after this) breaks anything in the Dropbox codebase. |
|
The Travis failure here is just because the branch I used doesn't have #2039. This PR should be safe to merge. |
gvanrossum
approved these changes
Apr 11, 2018
|
Yeah, I'm going to have to cp just the fix for #2039 -- the argparse
changes do break our internal codebase, and I don't want to have to sort
that out under time pressure.
|
yedpodtrzitko
pushed a commit
to yedpodtrzitko/typeshed
that referenced
this pull request
Jan 23, 2019
argparse.py checks for None in _get_optional_kwargs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
argparse.py checks for None in _get_optional_kwargs.