Skip to content

smtplib improvements #2419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 28, 2018
Merged

smtplib improvements #2419

merged 3 commits into from
Aug 28, 2018

Conversation

srittau
Copy link
Collaborator

@srittau srittau commented Aug 28, 2018

  • Mark SMTP attibutes with class defaults with "= ..."
  • Add SMTP.command_encoding
  • Annotate SMTP.exit()
  • Add SMTP.auth() et al.
  • Add LMTP_PORT constant

srittau added 2 commits August 28, 2018 03:25
@srittau
smtplib improvements
5be3f93 
* Mark SMTP attibutes with class defaults with "= ..."
* Add SMTP.command_encoding
* Annotate SMTP.__exit__()
* Add SMTP.auth() et al.
@srittau
Add LMTP_PORT constant
6b799fe
srittau
srittau commented Aug 28, 2018
View reviewed changes
stdlib/3/smtplib.pyi
@overload
def __call__(self, challenge: None = ...) -> Optional[str]: ...
@overload
def __call__(self, challenge: bytes) -> str: ...
Copy link
Collaborator Author

@srittau srittau Aug 28, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

authobject() is documented to return bytes, but this neither matches the implementation nor the return values of auth_cram_md5() et al.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Filed as bpo-34525 and PR python/cpython#8965.

@JelleZijlstra JelleZijlstra merged commit bbe9b94 into python:master Aug 28, 2018
@srittau srittau deleted the smtplib branch August 28, 2018 07:51
cocoatomo pushed a commit to cocoatomo/typeshed that referenced this pull request Sep 8, 2018
@srittau @cocoatomo
smtplib improvements (python#2419)
32d92ff 
* Mark SMTP attibutes with class defaults with "= ..."
* Add SMTP.command_encoding
* Annotate SMTP.__exit__()
* Add SMTP.auth() et al.
* Add LMTP_PORT constant
yedpodtrzitko pushed a commit to yedpodtrzitko/typeshed that referenced this pull request Jan 23, 2019
@srittau
smtplib improvements (python#2419)
bba6b30 
* Mark SMTP attibutes with class defaults with "= ..."
* Add SMTP.command_encoding
* Annotate SMTP.__exit__()
* Add SMTP.auth() et al.
* Add LMTP_PORT constant
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@srittau @JelleZijlstra