Add FullLoader class to third_party/2and3/yaml/loader.pyi #3035
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srittau
requested changes
Jun 6, 2019
third_party/2and3/yaml/loader.pyi
Outdated
| @@ -8,6 +8,9 @@ from yaml.resolver import BaseResolver, Resolver | |||
| class BaseLoader(Reader, Scanner, Parser, Composer, BaseConstructor, BaseResolver): | |||
| def __init__(self, stream) -> None: ... | |||
|
|
|||
| class FullLoader(Reader, Scanner, Parser, Composer, SafeConstructor, Resolver): | |||
There was a problem hiding this comment.
This actually derives from FullConstructor, which is a sub-class of SafeConstructor. Since we don't have stubs for that class, yet, I see two options:
- Add
FullConstructortoyaml.constructor.pyi, possible marked with# incompleteand use that. - Just add a comment explaining that
FullConstructorwould be correct here.
There was a problem hiding this comment.
Doh! Thanks for catching that. Fixed in a second commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The yaml module has added the FullLoader class, and it is recommended in their documentation when calling yaml.load(). Adding a type definition here.