sys: refine the return type of sys.exc_info() #3111
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I believe that either all of the items are None or none of them are. Reflect that in the type. This was attempted initially in python#246 but apparently mypy didn't allow unpacking given such a union, but it does now (checked with mypy 0.711). The (incorrect) TODO from that PR was removed in commit 25ac4d6 but the commit message noted that this change is desirable.
|
In the referenced commit message, @srittau suggested using a generic (presumably bounded by |
srittau
approved these changes
Jul 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe that either all of the items are None or none of them are.
Reflect that in the type.
This was attempted initially in
#246
but apparently mypy didn't allow unpacking given such a union, but it
does now (checked with mypy 0.711).
The (incorrect) TODO from that PR was removed in commit
25ac4d6 but the commit message noted
that this change is desirable.