@rchen152 I have another pytype failure that I am unclear about: https://travis-ci.org/python/typeshed/jobs/596595124. "TypeError: Unexpected definition type <class 'NoneType'>", although all uses of None look ok to me and not like something that hasn't been done before in other stubs. Maybe it's the @overload + @classmethod? Unfortunately I can't get pytype to run locally:

$ ~/.pyenv/versions/3.6.9/bin/pytype stdlib/3/importlib/metadata.pyi 
usage: pytype [options] input [input ...]
pytype: error: Need an input.

I'll take a look. To run pytype locally, the command is pytype-single --parse-pyi --module-name=<whatever> -V<major.minor> <filepath>.

Huh. pytype can't parse nested classes inside a version check.

class Foo:
  class Bar: ...

parses fine.

if sys.version_info >= (3, 8):
  class Foo:
    class Bar: ...

crashes the parser. I'll work on a fix.

This passes CI now