Skip to content

extract asyncio exceptions into a separate module #3356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 13, 2019
Merged

extract asyncio exceptions into a separate module #3356

merged 1 commit into from
Oct 13, 2019

Conversation

Hanaasagi
Copy link
Contributor

It will resolve #3231 .

srittau
srittau approved these changes Oct 13, 2019
View reviewed changes
stdlib/3/asyncio/exceptions.pyi
consumed: int
def __init__(self, message: str, consumed: int) -> None: ...

__all__: List[str]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

__all__ should should not be typed (event if existing stubs do this). If __all__ exists, it has the same meaning as in implementation files. In this case it's not necessary.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for correcting.

@srittau srittau merged commit 2bd1b75 into python:master Oct 13, 2019
@srittau srittau mentioned this pull request Oct 13, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srittau srittau srittau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Python 3.8: asyncio exceptions have extracted into a separate module
2 participants
@Hanaasagi @srittau