stdlib/3/ast: add visit_* methods to NodeVisitor #3796
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is re. #3767 (cc @hauntsaninja). I think it's either this (have all) or remove the |
|
Hmm stubtest complains " |
|
I think it makes sense to have these defined for the reason you stated. We probably need stubtest overrides. |
isidentical
reviewed
Mar 3, 2020
NodeVisitor recurses over an AST tree. When encountering a node, it
checks if a method called `visit_{node.__class__.__name__}` exists, and
calls it if so, otherwise calls the generic visitor.
Add the possible methods to NodeVisitor. This is not exactly correct,
since the methods don't *actually* exist on NodeVisitor, e.g.
`NodeVisitor().visit_Module(...)` doesn't work. But it's nice for
subclasses to know which methods they can override and which type they
should have.
bc3b64b to
1b1292a
Compare
|
I added the methods to the stubtest whitelist, and it passes now. |
srittau
approved these changes
Mar 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NodeVisitor recurses over an AST tree. When encountering a node, it
checks if a method called
visit_{node.__class__.__name__}exists, andcalls it if so, otherwise calls the generic visitor.
Add the possible methods to NodeVisitor. This is not exactly correct,
since the methods don't actually exist on NodeVisitor, e.g.
NodeVisitor().visit_Module(...)doesn't work. But it's nice forsubclasses to know which methods they can override and which type they
should have.