Skip to content

Mock and MagickMock subclassing NonCallableMock #3871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 24, 2020
Merged

Mock and MagickMock subclassing NonCallableMock #3871

merged 3 commits into from
Mar 24, 2020

Conversation

rodrigondec
Copy link
Contributor

@rodrigondec rodrigondec commented Mar 20, 2020 •
edited
Loading

I forgot to subclass Mock and MagicMock on my quest to have the best stubs on PR #3846

@srittau

srittau
srittau requested changes Mar 20, 2020
View reviewed changes
Copy link
Collaborator

@srittau srittau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@rodrigondec rodrigondec requested a review from srittau March 24, 2020 14:09
@srittau srittau merged commit 4b14e24 into python:master Mar 24, 2020
@JelleZijlstra JelleZijlstra mentioned this pull request Jun 25, 2020
Closed
@staticdev staticdev mentioned this pull request Jun 25, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srittau srittau srittau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rodrigondec @srittau