python3: remove _subprocess #4022
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This doesn't seem to exist in Python 3.5, which is the earliest Python3 we support, and this folder is in stdlib/3
|
The stubs look like they're Windows-only. I found release notes saying the module was removed in 3.3.0a3, so we can safely get rid of it. |
JelleZijlstra
approved these changes
May 16, 2020
|
Apparently there's some mypy unit test relying on this module. Would you mind submitting a PR to mypy to resolve it? |
hauntsaninja
pushed a commit
to hauntsaninja/mypy
that referenced
this pull request
May 17, 2020
They depend heavily on _subprocess, which is no longer a module that exists: python/typeshed#4022 (comment)
|
Opened a PR against mypy in python/mypy#8838 |
JukkaL
pushed a commit
to python/mypy
that referenced
this pull request
May 18, 2020
They depend heavily on _subprocess, which is no longer a module that exists: python/typeshed#4022 (comment) Co-authored-by: hauntsaninja <>
|
python/mypy#8838 is merged now, so maybe we can re-run CI |
vishalkuo
pushed a commit
to vishalkuo/typeshed
that referenced
this pull request
Jun 26, 2020
This doesn't seem to exist in Python 3.5, which is the earliest Python3 we support, and this folder is in stdlib/3 Co-authored-by: hauntsaninja <>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doesn't seem to exist in Python 3.5, which is the earliest Python3
we support, and this folder is in stdlib/3