Make TypeAlias stub a valid annotation #4354
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
facebook-github-bot
pushed a commit
to facebook/pyre-check
that referenced
this pull request
Jul 24, 2020
Summary: Include fix to make explicit aliases work again: python/typeshed#4354 Reviewed By: sinancepel Differential Revision: D22675787 fbshipit-source-id: 6809ae93e27767d9c35749b841e40cd488645846
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in #3933 and #3966 resulted in removal of
TypeAliasas a class exported from the typing module.#4243 makes
TypeAliasavailable intyping_extensions, but it is defined as a variable as opposed to a class that can be used as a valid type (https://mypy.readthedocs.io/en/latest/common_issues.html#variables-vs-type-aliases).Proposing this change to ensure syntax like
x: TypeAlias = intas described in PEP 613 is still valid for type checkers.