[stdlib][unittest] Fix mock.call(...) types #4374
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
stubtest failure seems unrelated and Travis CI fails with pytype issue I have no idea how to resolve, as forward refs should be supported just fine |
|
@jermenkoo You can merge current HEAD to fix the stubtest problem. I think pytype doesn't like the quoted forward reference. It's also not necessary in stubs, so just removing the quotes should fix the problem. |
|
Thanks! TIL stubs work fine even without the quoted forward references :) |
srittau
approved these changes
Jul 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3846 defined
_Callandcallfromunittest.mock, however the exported types are not correct; as:c = call(), c = c.x(), ...) always return_Call(https://github.com/python/cpython/blob/3.8/Lib/unittest/mock.py#L2468)callreturns_Call, not any (https://github.com/python/cpython/blob/3.8/Lib/unittest/mock.py#L2545)These 2 make
pyretrip, making code such asm = Mock(), m.assert_has_calls([<call_list_here>])not compatible as call list will be refined asAnyas opposed to_Call.