Skip to content

Complete msvcrt #4548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 18, 2020
Merged

Complete msvcrt #4548

merged 3 commits into from
Sep 18, 2020

Conversation

srittau
Copy link
Collaborator

@srittau srittau commented Sep 17, 2020

No description provided.

srittau added a commit to srittau/typeshed-completion that referenced this pull request Sep 17, 2020
@srittau
Copy link
Collaborator Author

srittau commented Sep 17, 2020

Once again, CI has passed, which isn't reflected correctly here.

@CraftSpider
Copy link
Contributor

Looks good to me, one comment:
I locally have some variables starting with SEM_ and CRT_, do those not exist on all platforms?

@srittau
Copy link
Collaborator Author

srittau commented Sep 18, 2020

I just went with what was documented for this PR. It's possible that the module contains more undocumented things.

@CraftSpider CraftSpider merged commit 4e88557 into python:master Sep 18, 2020
@srittau srittau deleted the msvcrt branch September 18, 2020 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants