Skip to content

update and complete pymysql.connections stubs to 0.10.1 #4702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 29, 2020
Merged

update and complete pymysql.connections stubs to 0.10.1 #4702

merged 1 commit into from
Oct 29, 2020

Conversation

vbarbaresi
Copy link
Contributor

Updated pymysql.connections and checked with stubtest

Used https://github.com/PyMySQL/PyMySQL/blob/v0.10.1/pymysql/connections.py for reference

Solves part of #4487, other modules can still be updated

srittau
srittau approved these changes Oct 29, 2020
View reviewed changes
Copy link
Collaborator

@srittau srittau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I only check cursory, but LGTM.

@srittau srittau merged commit eb2fff7 into python:master Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srittau srittau srittau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vbarbaresi @srittau