Skip to content

Add annotation for collections.ChainMap.__missing__(key) #4784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 23, 2020

Conversation

natemcmaster
Copy link
Contributor

@natemcmaster natemcmaster commented Nov 23, 2020

This method has been present in the CPython implementation since ChainMap's introduction in 3.3.

https://github.com/python/cpython/blob/v3.3.0/Lib/collections/__init__.py#L783

This method has been present in the CPython implementation since its introduction in 3.3.
https://github.com/python/cpython/blob/v3.3.0/Lib/collections/__init__.py\#L783
Copy link
Collaborator

@hauntsaninja hauntsaninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, lgtm!

@natemcmaster natemcmaster marked this pull request as ready for review November 23, 2020 05:33
@srittau srittau merged commit 62546ed into python:master Nov 23, 2020
@natemcmaster natemcmaster deleted the chainmap branch November 23, 2020 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants