Skip to content

Add functools._make_key #5370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
May 8, 2021
Merged

Add functools._make_key #5370

merged 7 commits into from
May 8, 2021

Conversation

wiseaidev
Copy link
Contributor

@wiseaidev wiseaidev commented May 7, 2021 •
edited
Loading

Signed-off-by: Harmouch101 mahmoudddharmouchhh@gmail.com

Fixed #5368

Please refer to the python implementation here.

@github-actions
Copy link
Contributor

github-actions bot commented May 7, 2021

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@srittau
Copy link
Collaborator

srittau commented May 7, 2021

Apart from the error found by CI: Please use built-in generics (list etc.) instead of importing from typing.

Akuli
Akuli requested changes May 7, 2021
View reviewed changes
@wiseaidev wiseaidev force-pushed the add-make-key branch 2 times, most recently from 8def030 to df9a807 Compare May 7, 2021 18:53
Akuli
Akuli requested changes May 7, 2021
View reviewed changes
@github-actions
Copy link
Contributor

github-actions bot commented May 7, 2021

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

1 similar comment
@github-actions
Copy link
Contributor

github-actions bot commented May 7, 2021

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@wiseaidev wiseaidev force-pushed the add-make-key branch 2 times, most recently from 74176e3 to ff64a13 Compare May 7, 2021 19:46
@wiseaidev
Add functools._make_key
faf375d 
Signed-off-by: Harmouch101 <mahmoudddharmouchhh@gmail.com>
Akuli
Akuli reviewed May 7, 2021
View reviewed changes
@Akuli
Copy link
Collaborator

Akuli commented May 7, 2021

When we are done with the reviews, you need to run black and isort (or ask me to run them).

Also, don't squash the commits or commit with --amend. We prefer multiple separate commits, so that it's easier to see what is happening. When we merge the pull request, they are combined into a single commit anyway.

@Akuli Akuli mentioned this pull request May 7, 2021
Merged
@wiseaidev
Copy link
Contributor Author

Alright!

@wiseaidev
fixed minor error!
753d185 
Signed-off-by: Harmouch101 <mahmoudddharmouchhh@gmail.com>
@wiseaidev
Copy link
Contributor Author

@Akuli, Everything has changed as intended. Ready to trigger Github Actions! Let's goooooo.

@wiseaidev
fixed black and isort errors related to import
6aef232 
Signed-off-by: Harmouch101 <mahmoudddharmouchhh@gmail.com>
Akuli
Akuli requested changes May 7, 2021
View reviewed changes
Copy link
Collaborator

@Akuli Akuli left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should help with the errors. Like I said, you will also need to run black and isort to get rid of their errors.

@wiseaidev
replace list and set builtins by the corresponding ones from the typi…
7318f4b 
…ng module

Signed-off-by: Harmouch101 <mahmoudddharmouchhh@gmail.com>
@Akuli
Copy link
Collaborator

Akuli commented May 7, 2021

Seems like you need to isort again

@wiseaidev
ignore the signature of the "__hash__" function because it sucks
eec12f3 
Signed-off-by: Harmouch101 <mahmoudddharmouchhh@gmail.com>
@wiseaidev
Copy link
Contributor Author

@Akuli, Waiting for your response...

wiseaidev added 2 commits May 8, 2021 22:14
@wiseaidev
fixed flake & isort errors!
0f2713e 
Signed-off-by: Harmouch101 <mahmoudddharmouchhh@gmail.com>
@wiseaidev
Added a missing member of the _HashedSeq class after running a stubte…
8dce87b 
…st on functools

Signed-off-by: Harmouch101 <mahmoudddharmouchhh@gmail.com>
@wiseaidev
Copy link
Contributor Author

I have added the hashvalue property discovered using the following cmd:

$ stubtest functools --concise --custom-typeshed-dir .
functools._HashedSeq.hashvalue is not present in stub

@wiseaidev
Copy link
Contributor Author

@hauntsaninja, can you trigger the workflows one more time cause I've added a couple of chnges?

@Akuli Akuli merged commit 0804505 into python:master May 8, 2021
@Akuli Akuli mentioned this pull request May 9, 2021
Merged
@wiseaidev wiseaidev deleted the add-make-key branch May 17, 2021 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra left review comments

@Akuli Akuli Akuli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Module 'functools' has no attribute '_make_key'
4 participants
@wiseaidev @srittau @Akuli @JelleZijlstra