Simplify stub for iter() #6297
Closed
Simplify stub for iter() #6297
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As discussed [here](python#6292 (comment)) (cc: @JelleZijlstra)
|
Diff from mypy_primer, showing the effect of this PR on open source code: vision (https://github.com/pytorch/vision.git)
+ torchvision/datasets/utils.py:34: error: Need type annotation for "chunk" [var-annotated]
+ torchvision/datasets/utils.py:56: error: Need type annotation for "chunk" [var-annotated]
poetry (https://github.com/python-poetry/poetry.git)
+ poetry/publishing/uploader.py:145: error: Need type annotation for "content"
paasta (https://github.com/yelp/paasta.git)
+ paasta_tools/utils.py:2673: error: Need type annotation for "linebytes"
twine (https://github.com/pypa/twine.git)
+ twine/package.py:290: error: Need type annotation for "content"
ignite (https://github.com/pytorch/ignite)
+ ignite/utils.py:318: error: Need type annotation for "byte_block" [var-annotated]
sockeye (https://github.com/awslabs/sockeye.git)
+ sockeye/data_io.py:425: error: Need type annotation for "random_shard_iter"
+ sockeye/data_io.py:425: error: Argument 1 to "iter" has incompatible type "Callable[[], int]"; expected "Callable[[], <nothing>]"
+ sockeye/data_io.py:425: error: Return statement in function which does not return
|
|
Yeah, this doesn't really seem to work. I can think of a few ways round it, but I'm not sure any of them would actually be an improvement over the current stub. So I think I'll just close this, unless anyone disagrees? |
|
Too bad, thanks for trying! I'm honestly surprised there are enough uses of two-argument iter() that mypy-primer was helpful here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed here (cc: @JelleZijlstra)