Adding PyMySQL and SQLAlchemy stubs for Python 3 #647
Conversation
Stubs were auto-generated and manually modified using mypy/stubgen.py and Python 3.5. Closes the following ticket: python#631
tests make problems for mypy
|
Deleted a broken stub file |
just changed sqlalchemy/util/compat:37 unicode -> str, everything else is unchanged
|
added sqlalchemy to third_party/2and3 |
|
@ghagerer Did you realize there are already stubs for sqlalchemy in third_party/2/sqlalchemy/? We shouldn't have stubs for the same package in both /2 and /2and3. How do your stubs compare to those? |
|
Both are 100% the same except one line: sqlalchemy/util/compat.pyi:37: In that way both Should I delete the third_party/2/sqlalchemy folder from my fork and then merge? |
|
That sounds like a good plan. Maybe you can change that type alias to using typing.Text, which does the right thing regardless of Python version. |
|
Activity seems to have died down, could one of us take over this PR and finish the remaining changes? Looking forward to getting this merged. |
|
Please go ahead and submit a new PR based on this one.
…On Mon, Nov 28, 2016 at 6:43 AM, Aleksander Vognild Burkow < ***@***.***> wrote:
Activity seems to have died down, could one of us take over this PR and
finish the remaining changes?
(deleting third_party/2/sqlalchemy and using the type alias in the one
file).
Looking forward to getting this merged.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#647 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ACwrMq3cMQDMhlpgO-5ZXuL-au8FD68Mks5rCuiSgaJpZM4Kl69S>
.
--
--Guido van Rossum (python.org/~guido)
|
This is just to trigger the test to run again -- I have reasons to believe this PR is out of date.
|
Whoops, there are two parts here. One part is the sqlalchemy stubs which IIUC is superseded by #719. But the other part is pymysql which is not there AFAICT. So reopening in the hope of disentangling the two PRs... |
63ba0ab to
7853c26
Compare
|
@ghagerer Can I entice you to submit your stubs for pymysql separately? Then hopefully your work on those can be merged. If we don't hear from you in a few weeks we'll close this PR without action. |
|
I'd closed this in favor of #857 except I'm still hopeful to also get the pymysql stubs in. |
(Original by @ghagerer, extracted from #647 by @WouldYouKindly.)
|
Superseded by #861. |
Fixes python/typing#643 (Use ignore whitespace option to review this, since it mostly just indents a bunch of stuff.) PR summary: * Update Travis config to run on a bunch of newer Python versions (including 3.8-dev). * Only run `typing` tests on Python 3.6 or older, starting from Python 3.7 development of `typing` moved to CPython repo, where it was significantly reworked. We still run `typing_extension` tests on all versions. * Update `repr()` tests in `typing_extensions` to conditionally expect correct module name. * Add `TypedDict` to `__all__`. * Use `Final`, `Literal`, etc. from `typing` if those are available (as we do for other things). * Rename `@runtime` to `@runtime_checkable` in `typing_extensions` (I think we can keep `@runtime` in `typing_extensions` as an alias for backwards compatibility). Note this only updates Python 3 version of `typing_extensions`. There will be a corresponding update for the Python 2 version of `typing_extensions` as part of python/typing#648
Stubs were auto-generated and manually modified using mypy/stubgen.py and Python 3.5. Closes the following ticket:
Stubs for PyMySQL #631