Skip to content

Use stubtest 0.920 #6589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 37 commits into from
Dec 17, 2021
Merged

Use stubtest 0.920 #6589

merged 37 commits into from
Dec 17, 2021

Conversation

hauntsaninja
Copy link
Collaborator

No description provided.

@hauntsaninja
Copy link
Collaborator Author

hauntsaninja commented Dec 16, 2021 •
edited
Loading

unittest._log seems to be unconditionally imported, so mypy's complaint on the lower Python versions looks correct. Surprised pyright doesn't complain, maybe pyright doesn't listen to submodules in VERSIONS

Looks like we've picked up some stubtest changes as well (several from the decision to follow type aliases). I'm going to mostly allowlist these.

@hauntsaninja hauntsaninja marked this pull request as draft December 16, 2021 00:38
@hauntsaninja
Copy link
Collaborator Author

hauntsaninja commented Dec 16, 2021 •
edited
Loading

@srittau is there a good way to trigger stubtest on all third party stubs on this PR?
I just did it the dumb way for now

@AlexWaygood
Copy link
Member

@srittau is there a good way to trigger stubtest on all third party stubs on this PR?
I just did it the dumb way for now

Wait, shouldn't you have done that on this PR, rather than the other PR? The other PR doesn't have mypy updated yet

@github-actions

This comment has been minimized.

Sign in to view
1 similar comment
@github-actions

This comment has been minimized.

Sign in to view
@hauntsaninja
Copy link
Collaborator Author

@AlexWaygood Oooops, yes, I should! I confused myself because I wasn't sure whether to separate out actual stub changes into their own PRs. Fixing....

@hauntsaninja @AlexWaygood
Update tests/stubtest_allowlists/py310.txt
adb5315 
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@github-actions

This comment has been minimized.

Sign in to view
@srittau
Copy link
Collaborator

srittau commented Dec 16, 2021

Maybe it's easier to temporarily use stubtest 0.910 and do the upgrade separately.

@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
1 similar comment
@github-actions

This comment has been minimized.

Sign in to view
AlexWaygood added a commit to AlexWaygood/typeshed that referenced this pull request Dec 16, 2021
@AlexWaygood
Add timeout attribute to _socket.socket
28f2d6c 
Helps unblock python#6589 (new error uncovered by upgrading stubtest)
@AlexWaygood AlexWaygood mentioned this pull request Dec 16, 2021
Merged
AlexWaygood added a commit to AlexWaygood/typeshed that referenced this pull request Dec 16, 2021
@AlexWaygood
Correct sre_parse.State.opengroup
7a1f958 
New error picked up by updated stubtest; helps unblock python#6589
@AlexWaygood AlexWaygood mentioned this pull request Dec 16, 2021
Merged
@srittau
Copy link
Collaborator

srittau commented Dec 16, 2021

The only thing left in master are the stubtest fixes. Should we close this and open a new PR?

@Akuli Akuli mentioned this pull request Dec 16, 2021
Closed
srittau
srittau reviewed Dec 16, 2021
View reviewed changes
Copy link
Collaborator

@srittau srittau left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stubtest 0.920 should also be reenabled in .github/workflows/stubtest.yml.

Well, this change is already in master. :)

@hauntsaninja hauntsaninja changed the title Upgrade mypy Use stubtest 0.920 Dec 16, 2021
@JelleZijlstra @srittau
Update .github/workflows/tests.yml
54a7ba8 
Co-authored-by: Sebastian Rittau <srittau@rittau.biz>
@srittau
Copy link
Collaborator

srittau commented Dec 16, 2021

https://github.com/python/typeshed/actions/runs/1589196055 for a guide on what fails at the moment.

BTW: If you push your branch directly into the python/typeshed repo, we can run the "stubtest" workflow against it manually now.

@hauntsaninja
Copy link
Collaborator Author

Okay, I think this should be good. Here's a GA run showing that stubtest for third party stubs also succeeds: https://github.com/python/typeshed/runs/4542782687?check_suite_focus=true

@hauntsaninja hauntsaninja marked this pull request as ready for review December 17, 2021 07:17
@Akuli Akuli merged commit 2ad00c9 into python:master Dec 17, 2021
@hauntsaninja hauntsaninja deleted the upgrade-mypy branch December 17, 2021 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Akuli Akuli Akuli left review comments

@AlexWaygood AlexWaygood AlexWaygood left review comments

@srittau srittau srittau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hauntsaninja @AlexWaygood @srittau @Akuli @JelleZijlstra