Skip to content

Add regex stubs #6713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
Dec 30, 2021
Merged

Add regex stubs #6713

merged 18 commits into from
Dec 30, 2021

Conversation

jpy-git
Copy link
Contributor

@jpy-git jpy-git commented Dec 27, 2021

This PR closes #6710.

Aim is to provide typing stubs for the regex package.
This regex implementation is backwards-compatible with the standard 're' module, but offers additional functionality.
Github: https://github.com/mrabarnett/mrab-regex
PyPI: https://pypi.org/project/regex/

I'm opening this as a draft as I have a couple questions about how to reference types for classes defined in C code (will annotate the PR with the questions). Any help/suggestions are greatly appreciated 😄

jpy-git
jpy-git commented Dec 27, 2021
View reviewed changes
Copy link
Contributor Author

@jpy-git jpy-git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some direction on these points (plus any general improvements) would be really appreciated, thanks! 😄

AlexWaygood
AlexWaygood reviewed Dec 28, 2021
View reviewed changes
Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the latest mypy release, we no longer need uppercase Tuple (and attempting to import it will cause CI to fail after the changes to check_new_syntax that I introduced in #6717 🙂)

@jpy-git jpy-git changed the title Add initial regex stubs Add regex stubs Dec 29, 2021
jpy-git
jpy-git commented Dec 29, 2021
View reviewed changes
Copy link
Contributor Author

@jpy-git jpy-git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be ready for review now 😄

@jpy-git jpy-git marked this pull request as ready for review December 29, 2021 01:40
AlexWaygood
AlexWaygood reviewed Dec 30, 2021
View reviewed changes
@LeeeeT
Copy link
Contributor

LeeeeT commented Dec 30, 2021

Thank you so much! Your PR is just in time 🚀🚀🚀

jpy-git and others added 2 commits December 30, 2021 13:21
@jpy-git @AlexWaygood
Update stubs/regex/regex/regex.pyi
fca60fb 
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@jpy-git
Remove unnecessary overrides
7944312
Akuli
Akuli reviewed Dec 30, 2021
View reviewed changes
Akuli
Akuli reviewed Dec 30, 2021
View reviewed changes
@jpy-git jpy-git mentioned this pull request Dec 30, 2021
Closed
Akuli
Akuli approved these changes Dec 30, 2021
View reviewed changes
Copy link
Collaborator

@Akuli Akuli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Akuli Akuli merged commit fbf5982 into python:master Dec 30, 2021
@jpy-git
Copy link
Contributor Author

jpy-git commented Dec 30, 2021

Awesome, thanks @Akuli and @AlexWaygood for the great reviews 😄

@jpy-git jpy-git deleted the regex_stubs branch December 30, 2021 19:17
This was referenced Dec 30, 2021
Merged
Open
richardjharris
richardjharris reviewed Feb 21, 2022
View reviewed changes
stubs/regex/regex/_regex.pyi
) -> Scanner[AnyStr]: ...

@final
class Match(Generic[AnyStr]):
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this missing __getitem__? After updating some modules I now get hundreds of "__getitem__" method not defined on type "Match[str]" errors.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not using regex and have not investigated, but this seems likely. re.Match (or rather typing.Match) also has a __getitem__() field. Cc @jpy-git

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, will make a PR 👍

@jpy-git jpy-git mentioned this pull request Feb 23, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srittau srittau srittau left review comments

@richardjharris richardjharris richardjharris left review comments

@AlexWaygood AlexWaygood AlexWaygood left review comments

@Akuli Akuli Akuli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add typing stubs for regex package
6 participants
@jpy-git @LeeeeT @srittau @richardjharris @Akuli @AlexWaygood