Skip to content

DO-NOT-MERGE: Import from collections.abc rather than typing in builtins #6724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

DO-NOT-MERGE: Import from collections.abc rather than typing in builtins #6724

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
257dc6c
No crash is caused for the vast majority of `collections.abc` imports
AlexWaygood Dec 28, 2021
83646a6
Importing `Sequence` from `collections.abc` causes a mypy crash
AlexWaygood Dec 28, 2021
57361f1
Importing `MutableSequence` from `collections.abc` also causes a crash
AlexWaygood Dec 28, 2021
4506274
Importing `Sequence` and `MutableSequence` from `collections.abc` als…
AlexWaygood Dec 28, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 12 additions & 10 deletions stdlib/builtins.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,27 +22,29 @@ from _typeshed import (
SupportsTrunc,
SupportsWrite,
)
from io import BufferedRandom, BufferedReader, BufferedWriter, FileIO, TextIOWrapper
from types import CodeType, TracebackType
from typing import (
IO,
AbstractSet,
Any,
BinaryIO,
from collections.abc import (
ByteString,
Callable,
Generic,
Iterable,
Iterator,
Mapping,
MutableMapping,
MutableSequence,
MutableSet,
NoReturn,
Protocol,
Reversible,
Sequence,
Set as AbstractSet,
Sized,
)
from io import BufferedRandom, BufferedReader, BufferedWriter, FileIO, TextIOWrapper
from types import CodeType, TracebackType
from typing import (
IO,
Any,
BinaryIO,
Generic,
NoReturn,
Protocol,
SupportsAbs,
SupportsBytes,
SupportsComplex,
Expand Down