Skip to content

fix several typos #6830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 5, 2022
Merged

fix several typos #6830

merged 1 commit into from
Jan 5, 2022

Conversation

Akuli
Copy link
Collaborator

@Akuli Akuli commented Jan 5, 2022

Found by running codespell stdlib/ stubs/ *.md, installed with pip install codespell==2.1.0.

It would be possible to add codespell to our CI, but it doesn't seem like a good idea to me:

  • It flags several false positives.
  • stubtest already ensures that most things are spelled correctly.
  • Outside comments, the only typo I have seen is misspelling suite_mask as suite_mast, fixed in Improve sys stubs #6816. It was in code that isn't very stubtest-friendly. But codespell doesn't flag it either, because mast is also a valid word.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 5, 2022

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@srittau srittau merged commit a7886bf into python:master Jan 5, 2022
@srittau
Copy link
Collaborator

srittau commented Jan 5, 2022

While I don't mind spelling fixes in comments, I don't think they should be a CI blocker. Especially since we can't do anything about misspelled function/field names.

@Akuli Akuli deleted the typos branch January 5, 2022 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants