Fix several methods that should be `async def`, but aren't #7107

AlexWaygood · 2022-02-02T14:03:41Z

These were discovered using an AST script looking for non-async definitions of __anext__, asend, athrow, aclose, __aenter__ and __aexit__. (I manually checked them all.)

github-actions · 2022-02-02T14:15:09Z

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

AlexWaygood added 3 commits February 2, 2022 13:59

Fix several methods that should be async def, but aren't

32b881a

Update __init__.pyi

71cec47

Update locks.pyi

12a88b7

This comment has been minimized.

Sign in to view

srittau approved these changes Feb 2, 2022

View reviewed changes

srittau merged commit 584336a into python:master Feb 2, 2022

AlexWaygood deleted the async branch February 2, 2022 14:18

AlexWaygood mentioned this pull request Feb 18, 2022

stubtest: error if a function is async at runtime but not in the stub (and vice versa) python/mypy#12212

Merged

AlexWaygood mentioned this pull request Mar 14, 2022

Improve various signatures that shouldn't be async def, but currently are #7491

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix several methods that should be `async def`, but aren't #7107

Fix several methods that should be `async def`, but aren't #7107

AlexWaygood commented Feb 2, 2022

This comment has been minimized.

This comment has been minimized.

github-actions bot commented Feb 2, 2022

Fix several methods that should be async def, but aren't #7107

Fix several methods that should be async def, but aren't #7107

Conversation

AlexWaygood commented Feb 2, 2022

This comment has been minimized.

This comment has been minimized.

github-actions bot commented Feb 2, 2022

Fix several methods that should be `async def`, but aren't #7107

Fix several methods that should be `async def`, but aren't #7107