Skip to content

Increase pyright strictness when checking __all__ #7356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
Mar 2, 2022
Merged

Increase pyright strictness when checking __all__ #7356

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
45dfa04
Increase pyright strictness when checking `__all__`
AlexWaygood Feb 22, 2022
363893b
Update pyrightconfig.json
AlexWaygood Feb 22, 2022
a6eae32
Fix typo in `locale.__all__`
AlexWaygood Feb 22, 2022
466536e
Merge branch 'python:master' into pyright-all
AlexWaygood Feb 22, 2022
fb9f15c
Merge branch 'python:master' into pyright-all
AlexWaygood Feb 23, 2022
7ab2867
Merge branch 'python:master' into pyright-all
AlexWaygood Feb 23, 2022
c8f7d5b
Delete `Popen` from `asyncio.windows_utils.__all__`
AlexWaygood Feb 23, 2022
b86aa79
Merge remote-tracking branch 'origin/master' into pyright-all
AlexWaygood Feb 23, 2022
c2387d0
Fix typos in `re`
AlexWaygood Feb 23, 2022
2d3a5cd
Allow
AlexWaygood Feb 23, 2022
90f38ea
Merge branch 'python:master' into pyright-all
AlexWaygood Feb 24, 2022
9c18f92
Update types.pyi
AlexWaygood Feb 24, 2022
dd4e358
Merge branch 'master' into pyright-all
AlexWaygood Feb 25, 2022
a8e77b9
Merge remote-tracking branch 'origin/master' into pyright-all
AlexWaygood Feb 27, 2022
b98775d
Revert changes to allowlists and `windows_utils`
AlexWaygood Feb 27, 2022
9fd443b
Trailing whitespace
AlexWaygood Feb 27, 2022
30a4c97
Merge branch 'python:master' into pyright-all
AlexWaygood Feb 28, 2022
5e45cf4
Merge branch 'python:master' into pyright-all
AlexWaygood Mar 1, 2022
c334959
Merge branch 'python:master' into pyright-all
AlexWaygood Mar 1, 2022
c707a24
Merge branch 'python:master' into pyright-all
AlexWaygood Mar 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions pyrightconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,12 +43,10 @@
"reportInvalidTypeVarUse": "error",
"reportPropertyTypeMismatch": "error",
"reportSelfClsParameterName": "error",
"reportUnsupportedDunderAll": "error",
// Overlapping overloads cannot be enabled at this time because
// of the "fractions.Fraction.__pow__" method and "tasks.gather" function.
// Mypy's overlapping overload logic misses these issues (see mypy
// issue #10143 and #10157).
"reportOverlappingOverload": "none",
// Several stubs refer to symbols in __all__ that are conditionally
// declared based on platform or version checks.
"reportUnsupportedDunderAll": "none",
}
6 changes: 2 additions & 4 deletions pyrightconfig.stricter.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,12 +111,10 @@
"reportInvalidTypeVarUse": "error",
"reportPropertyTypeMismatch": "error",
"reportSelfClsParameterName": "error",
"reportUnsupportedDunderAll": "error",
// Overlapping overloads cannot be enabled at this time because
// of the "factions.Fraction.__pow__" method and "tasks.gather" function.
// of the "fractions.Fraction.__pow__" method and "tasks.gather" function.
// Mypy's overlapping overload logic misses these issues (see mypy
// issue #10143 and #10157).
"reportOverlappingOverload": "none",
// Several stubs refer to symbols in __all__ that are conditionally
// declared based on platform or version checks.
"reportUnsupportedDunderAll": "none",
}