Diff from mypy_primer, showing the effect of this PR on open source code:

pandera (https://github.com/pandera-dev/pandera)
- pandera/checks.py:74: error: Argument 1 to "ChainMap" has incompatible type "MappingProxyType[str, Any]"; expected "MutableMapping[str, Callable[..., Any]]"  [arg-type]
- pandera/model.py:362: error: Need type annotation for "attrs" (hint: "attrs: Dict[<type>, <type>] = ...")  [var-annotated]

pydantic (https://github.com/samuelcolvin/pydantic)
- pydantic/class_validators.py:332: error: Need type annotation for "all_attributes"  [var-annotated]
- pydantic/class_validators.py:332: error: Argument 1 to "ChainMap" has incompatible type "*List[MappingProxyType[str, Any]]"; expected "MutableMapping[<nothing>, <nothing>]"  [arg-type]

These are weird -- looks like this crossed the streams with #7423 being merged, maybe?

The boostedblob errors are unfortunate. They're in places like https://github.com/hauntsaninja/boostedblob/blob/eb6e95b41ba55c4c595cbe754d05a48f069ce42e/boostedblob/path.py#L328, where request.execute is an async CM. The new annotations make mypy catch on to the fact that async CMs can eat exceptions.

And yeah, not sure what caused the ChainMap changes.

Oh wait, I bet mypy special cases -> bool as "may swallow" and assumes that "bool | None" means "won't swallow". So we should probably just change _AsyncGeneratorContextManager.__aexit__ back; sorry for the thrash.

And now pyright in CI is complaining about shutil, which you didn't change.

And now pyright in CI is complaining about shutil, which you didn't change.

Yeah, it's because #7384 made chown unavailable on Windows, but it's still declared in __all__ on Windows. It wasn't picked up by CI running on that PR, because I increased pyright strictness for checking __all__ after that PR was filed.

Ah good catch

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉