Make several type aliases private #7661
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexWaygood
commented
Apr 18, 2022
| @@ -410,8 +410,6 @@ class InternalError(DatabaseError): ... | |||
| class NotSupportedError(DatabaseError): ... | |||
| class OperationalError(DatabaseError): ... | |||
|
|
|||
| OptimizedUnicode = str | |||
There was a problem hiding this comment.
This one doesn't seem to exist at runtime or be used in the stub
There was a problem hiding this comment.
It exists at runtime in 3.6-3.9: https://github.com/python/cpython/blob/3.6/Modules/_sqlite/module.c#L421, https://github.com/python/cpython/blob/636832fb2a4364ca2014aadecf4c35833eff4495/Modules/_sqlite/module.c#L439
Could you add it back with a version guard?
There was a problem hiding this comment.
Yup, I'd just figured it out from the mypy failures :)
There was a problem hiding this comment.
I'm not 100% sure whether it's better to do
OptimizedUnicode = stror
OptimizedUnicode: TypeAlias = stror
from builtins import str as OptimizedUnicodeThoughts?
This comment has been minimized.
This comment has been minimized.
JelleZijlstra
approved these changes
Apr 18, 2022
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
None of these exist at runtime, except for
sqlite3.dbapi2.OptimizedUnicode, which exists on <3.10. (All of these were picked up by python/mypy#12608.)