psycopg2: stub improvements #7964
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes an entry from python#7928 along with a number of other improvements. I went off the C code: https://github.com/psycopg/psycopg2/blob/master/psycopg/connection_type.c
Closed
18 tasks
This comment has been minimized.
This comment has been minimized.
AlexWaygood
reviewed
May 27, 2022
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
AlexWaygood
reviewed
May 28, 2022
JelleZijlstra
added a commit
to JelleZijlstra/typeshed
that referenced
this pull request
May 29, 2022
It doesn't usually find real issues in stubs. python#7964 (comment)
This comment has been minimized.
This comment has been minimized.
1 similar comment
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
AlexWaygood
reviewed
May 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an entry from #7928 along with a number of other improvements.
I went off the C code:
https://github.com/psycopg/psycopg2/blob/master/psycopg/connection_type.c