Skip to content

Fix assertAlmostEqual regression on mixed numeric types #8137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 27, 2022
Merged

Fix assertAlmostEqual regression on mixed numeric types #8137

merged 1 commit into from
Jun 27, 2022

Conversation

AlexWaygood
Copy link
Member

Fixes #8136

@github-actions
Copy link
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@AlexWaygood AlexWaygood requested a review from Akuli June 24, 2022 16:16
@srittau srittau merged commit 208d8e1 into master Jun 27, 2022
@srittau srittau deleted the almostequal branch June 27, 2022 06:57
@AlexWaygood AlexWaygood mentioned this pull request Jun 27, 2022
Merged
@ilevkivskyi ilevkivskyi mentioned this pull request Jul 8, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srittau srittau srittau approved these changes

@Akuli Akuli Awaiting requested review from Akuli

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

unittest assertAlmostEqual called with (int, float) now fails typecheck
2 participants
@AlexWaygood @srittau