ctypes: improve bytes handling #9029
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
srittau
approved these changes
Oct 31, 2022
| @@ -194,7 +194,7 @@ class _SimpleCData(Generic[_T], _CData): | |||
| class c_byte(_SimpleCData[int]): ... | |||
|
|
|||
| class c_char(_SimpleCData[bytes]): | |||
| def __init__(self, value: int | bytes = ...) -> None: ... | |||
| def __init__(self, value: int | bytes | bytearray = ...) -> None: ... | |||
There was a problem hiding this comment.
I failed to trace through the code for this, but I trust this is correct.
There was a problem hiding this comment.
I didn't find the code either but tried it in the REPL. This one allows bytearray but c_char_p doesn't.
| @@ -367,6 +367,8 @@ _ctypes.sizeof | |||
| # Allowlist entries that cannot or should not be fixed | |||
| # ========== | |||
|
|
|||
| ctypes.Array.raw # exists but stubtest can't see it | |||
There was a problem hiding this comment.
Nit: Maybe copy the comment from the stub?
JelleZijlstra
commented
Oct 31, 2022
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.