-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Pyright typecheck typeshed #9298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I meant to open against my own fork to validate what kindof changes would be necessary and if worth |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should definitely make sure pyright runs against test_cases, but don't think it's particularly important for pyright to run against the scripts or the testing code. I'm not seeing any real issues caught here, so mostly seems like it'd cause busywork for future contributions.
Edit: never mind, saw your edit :-)
@hauntsaninja It did allow me to find a couple typing issues with libraries used by typeshed (namely It also made me realize parsing METADATA.toml could be improved by parsing it in a central location, and returning a TypedDict. That way the default values are constant (no need to re-implement everytime), no need to revalidate keys everytime, no need to constantly do So even if in the end checking scripts and testing with pyright is not something that's done, it will have been a fruitful exercice for me. |
Yeah, agreed about METADATA.toml. In stub_uploader this is what I went with: https://github.com/typeshed-internal/stub_uploader/blob/main/stub_uploader/metadata.py Might be nice to have something like that in typeshed too |
No description provided.