Skip to content

Add stubs for show-in-file-manager #9313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Add stubs for show-in-file-manager #9313

wants to merge 1 commit into from

Conversation

pyhedgehog
Copy link
Contributor

@pyhedgehog pyhedgehog commented Dec 1, 2022

This PR adds stubs for show-in-file-manager.
After #5768 should be patched to use packaging.version.Version.

@AlexWaygood
Copy link
Member

AlexWaygood commented Dec 1, 2022

It looks like the upstream library is already fully annotated for this one. Have you asked them whether they might be prepared to add a py.typed marker, so that users are able to make use of those annotations? If they'd consider it, that would probably be a better option than adding stubs to typeshed.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 1, 2022

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@AlexWaygood
Copy link
Member

Closing, since the upstream package has added a py.typed file (they now just need to cut a new release)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants